This is a good hack. I posted it on plugins.b2evolution.net and marked it as 0.9.x compatible. If anyone tests it with 9.1, then let me know and I'll change it. I tried copying my old xmlsrv folder to my new Dawn installation and none of the feeds worked. Makes me suspect that something about the feeds has changed in the new version.

Good point. I'll see if the specific area in question changed, but hopefully a dawn user will try this and let us know pro or con before I have to crack open files.

Ok the problem I'm having is the per-post feed seems still to be listing ALL comments (not just those for the current post). Any ideas?

Edit: Note the version of b2evo I'm using is b2evo v 0.9.0.11 (with all current rpc patches.

I've gone back over the three files I've edited and can't find the problem. The RSS url for the per post comments feed looks ok, e.g. "http://mrshiney.froppy.com/blog/xmlsrv/rss2.comments_p.php?blog=2&postID=297"
but all the comments are definitely in there.

Where do we ensure that only comments with comment_post_id matching $postID get added to CommentsList?

Hi! Just saw your post on the other thread and asked you to do what you've done here. I see you're using v11 so that might be important. You should think about upgrading to dawn, not that the upgrade will fix your issue. Heck for all I know the hack won't work in dawn.

Where was I?

Oh yeah. I see on your feedback page that you have the link to the comments_p version of the file, and I see where you are still getting all the comments. Did you do the minor change to the comments_p file? Where you change '' to $postID? The link on your permalink page includes the post ID, so I have to wonder if you've got the change in your new file.

EdB wrote:

Did you do the minor change to the comments_p file? Where you change '' to $postID? The link on your permalink page includes the post ID, so I have to wonder if you've got the change in your new file.

Ed, thanks for your help thus far. Bear with me. :) Anyway, I think I made the correct change but let's see...

The following is from my rss2.comments_p.php file.

    require dirname(__FILE__).'/../b2evocore/_blog_main.php' ;
    $CommentList = & new CommentList( $blog, "'comment'", $show_statuses, $postID,    '',    'DESC',    '',    20 );
    header("Content-type: application/xml");

What do you mean about the PostID showing up on my permalink page? Doesn't that indicate that I DID make the change?

What I was refering to was what I see when I do a mouseover on your "subscribe to the comments on this post" link. I get http://mrshiney.froppy.com/blog/xmlsrv/rss2.comments_p.php?blog=2&postID=297 which obviously include both the comments_p file and the postID parameter. That means so far so good, but obviously rss2.comments_p.php isn't restricting the feed to comments for the post specified.

Take a look at your b2evocore/_class_commentlist.php file and look for "function CommentList(". That is the actual function I took advantage of to make this hack work. That is why you replaced '' with $postID in your rss2.comments_p.php file. Follow me? Your new file is telling that function "dude - I got a specific post I want the comments for so hook me up". Anyway the bits in my v12 installation that told me "a-ha!" are as follows:

$p = '',															// Restrict to specific post

and

		if( !empty( $p ) )
		{	// Restrict to comments on selected post
			$this->request .= ") WHERE comment_post_ID = $p AND ";
		}
		elseif( $blog > 1 )

Does your v11 version of b2evocore/_class_commentlist.php have the same stuff in it? Effectively what I did was realize you could tell that function to only show comments for one post, and took advantage of that in the new xmlsrv file. I then called up the xmlsrv file with the hack in your _feedback.php file, but it all goes belly up if v11 didn't have that bit.

EdB wrote:

Does your v11 version of b2evocore/_class_commentlist.php have the same stuff in it? Effectively what I did was realize you could tell that function to only show comments for one post, and took advantage of that in the new xmlsrv file. I then called up the xmlsrv file with the hack in your _feedback.php file, but it all goes belly up if v11 didn't have that bit.

It looks like my version of the file has the bits you mentioned. If I am understanding this correctly, adding $PostID as we did to that xmsrv file should be restricting the comments by post. Yet it doesn't.

Weird!

Shouldn't this bit (in _class_commentlist) include comment_post_id?

		// Call parent constructor:
		parent::DataObjectList( $tablecomments, 'comment_', 'comment_ID' );

I.e. change it to:

		// Call parent constructor:
		parent::DataObjectList( $tablecomments, 'comment_', 'comment_ID', 'comment_post_id' );

Edit: Well, making the change does not fix the problem. :( (Doesn't break anything, apparently, either!)

The first code you posted is what my v12 installation has, so I gotta figure it works for v12 that way. I have a question that might not even matter, but when you edited your _class_comment file did you type in $postID or paste the whole thing from the forums? I'm looking at the tabs between parameters and how pasting into a forum then copying back out makes them be a bunch of spaces, and wondering if it's related.

Just for kicks, how about editing your _class_comment file and making all the parameters in that function call have only one space after each comma.

Can't hurt at this point!

Also, you really should be thinking about upgrading. Skip right past v12 and go with dawn (v0.0.1). I know I have to upgrade, but my hacks are so sloppy that it'll take me forever to get it done and have the blog I want.

Yeah I did copy/paste from the forums. I just went over that line (in xmlsrv/rss2.comments_p.php right?) and fixed it so there is only one space after each comma.

Unfortunately it still doesn't work. :(

    require dirname(__FILE__).'/../b2evocore/_blog_main.php' ;
    $CommentList = & new CommentList( $blog, "'comment'", $show_statuses, $postID, '', 'DESC', '', 20 );

Edit: Btw about upgrading... Like you I have I lot of sloppy hacks installed. I don't plan on upgrading anytime soon. :)

Hi!

How to do this in b2 1.10.x ?

Thanks