Sounds like a nice plugin+hack! It would be really super cool if it could be done without a hack, but I know that means lots of stuff won't ever happen without it.

Cool though. I will probably be adding this one to a group blog I run. Thanks!

Thanks, I will try to copy some functions from upload.ctrl.php into plugin file and get rid of core modifications.

I moved everything to external file and there are no core hacks required now, but here is another problem.

I don't know why, but now param( 'var', 'string' ) function doesn't define a $var variable. What I mean...

param( 'var', 'string', '56' );
echo $var;

This returns Notice: Undefined variable: var message.

Plugin updated:
- no file edit required, install it and use ;)
- fixed many annoying bugs

OK, I uploaded the whole folder ( locales included )
Until I selected to specify a directory I got big RED error messages all over the upload window and no upload to the default media folder.

It sure is convenient and thanks

Well I didn't test it with *non-default* media dir path yet.
Is it /media/blogs/qwerty in your case or is it something unique?

Hi sam2kb, it's simply /media

Hi John, can you post that red message here please.

will do, I'll jump in and save the settings first :)

http://wow-factor.com/img/quick_upload.jpg

This is a system/server permissions problem, if it fails with this plugin it will fail with File Manager too as they share the same upload functions.

http://forums.b2evolution.net/viewtopic.php?t=12921
http://forums.b2evolution.net/viewtopic.php?t=14881
http://forums.b2evolution.net/viewtopic.php?t=11104

Yes, tell me about it :)
I'm happy with it as it is with directory tick option.

@sam2kb

I may be paranoid but I just found this on my Direct hits
http://mysite.com/htsrv/call_plugin.php?plugin_ID=127&method=quick_upload

This allows files to be uploaded. Now the question is, what's to stop someone other than me to do that?

I have disabled the plugin for now

Stop fretting ;)

The upload is protected by login

/**
 * @global boolean Is this an admin page? Use {@link is_admin_page()} to query it, because it may change.
 */
$is_admin_page = true;


$login_required = true;

¥

Ok, I'll buy that, I think!!

And even if you are logged in and have permissions to access backoffice you must also have permssions to upload files.
No worries about it ;)

Sam you are the best! I think this was the plug in I was using before I upgraded that let me upload right from the post form and I was missing that option!

Plugin updated.
Added "Link this file" feature for b2evo-2.4/3.x

1 tiny hick-up : the window stays in the back of your current browser. Have you fixed that allready since I last updated this plugin ?

the window stays in the back of your current browser

What does it mean? The pop-up window can't appears in the back of the main window when you click "Quick upload". And it's small enough to move it to the side if you want so.

Maybe we are talking about different things

What I meant to say :
You click on 'quick upload'... and it does what it is supposed to do. You click on 'add this code...' and voila : it does what you expect it to do.
At that point the quick upload window goes under your current window, the window were you actually are writing your post.
If you write another post after that, and you click again on 'quick upload' the window does not pop in front... it stays in the back... and for that is out of your reach...
Then I need to minimize my front window, close the quick upload window, maximize my actual post again, and click again on 'quick upload'

You are right. I'll check if there is any javascript function to bring the window to the front. I'm not a javascript fan ;)

if it can help : the 'normal' upload is working correctly
except that it shows a zillion thumbnails before you upload ;)

Done, zip updated. Thanks Topanga, I like your ideas :p

I'm trying to mess with this plugin a bit. Can someone tell me the best way to get a file extension for a file being uploaded? I just want everything after the "." I can do it in straight PHP, but the b2evo variables are so confusing to me. Any help is appreciated.

Open upload_window.php and change the following on line 488 to get the $file_ext variable.

// Store File object into DB:
$newFile->dbsave();

$file_ext = substr( $newFile->dget('name'), strrpos($newFile->dget('name'), '.') + 1 );

Good luck

Thank you so much. That did the trick. Let me give you a bit more insight into what I'm doing. I'm trying to add the functionality for the images to be resized when their uploaded.

As you mentioned, I'm putting my code after line 488, but I'm thinking it needs to be before that. Here's my code. I am learning PHP and B2Evo at the same time and things are slow-going. I appreciate the help.

// Store File object into DB:
$newFile->dbsave();
		
//MY STUFF
$filename = substr( $newFile->dget('name'), strrpos($newFile->dget('name'), 0) ); 
$ext = substr( $newFile->dget('name'), strrpos($newFile->dget('name'), '.') + 1 ); 
		
if ($ext == "jpg" or $ext == "gif" or $ext == "png") {
	if ($ext == "jpg") { $src = imagecreatefromjpeg($filename); }
	else if ($ext == "gif") { $src = imagecreatefromgif($filename); }
	else if ($ext == "png") { $src = imagecreatefrompng($filename); }
	list($width,$height)=getimagesize($filename);
	$newwidth=600;
	$newheight=($height/$width)*600;
	$tmp=imagecreatetruecolor($newwidth,$newheight);

imagecopyresampled($tmp,$src,0,0,0,0,$newwidth,$newheight,$width,$height);

			
	if ($ext == "jpg") { imagejpeg($tmp,$filename,100); }
	else if ($ext == "gif") { imagegif($tmp,$filename,100); }
	else if ($ext == "png") { imagepng($tmp,$filename,100); }
			
	imagedestroy($src);
	imagedestroy($tmp); 
}

Lay it on me! What have I done horribly wrong :?:
Here are the errors I get when I go to upload:

Warning: imagecreatefromjpeg(test.jpg) [function.imagecreatefromjpeg]: failed to open stream: No such file or directory in /*full path*/upload_window.php on line 497

Warning: getimagesize(test.jpg) [function.getimagesize]: failed to open stream: No such file or directory in /*full path*/upload_window.php on line 500

Warning: Division by zero in /*full path*/upload_window.php on line 502

Warning: imagecreatetruecolor() [function.imagecreatetruecolor]: Invalid image dimensions in /*full path*/upload_window.php on line 503

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /*full path*/upload_window.php on line 504

Warning: imagejpeg(): supplied argument is not a valid Image resource in /*full path*/upload_window.php on line 507

Warning: imagedestroy(): supplied argument is not a valid Image resource in /*full path*/upload_window.php on line 511

Warning: imagedestroy(): supplied argument is not a valid Image resource in /*full path*/upload_window.php on line 512

Warning: Cannot modify header information - headers already sent by (output started at /*full path*/upload_window.php:497) in /*full path*/upload_window.php on line 619

(the *full path* is replaced for this forum)

OK. I'm very close now! The images are being resized and uploaded successfully, but still getting one error. Here's my code now:

/*line 489:*/ 
$newFile->dbsave();
		
$ext = substr( $newFile->dget('name'), strrpos($newFile->dget('name'), '.') + 1 ); //GETS THE EXTENSION
$fullpath = $newFile->get_full_path();
	if ($ext == "jpg" or $ext == "gif" or $ext == "png") {
		/*496*/if ($ext == "jpg") { $src = imagecreatefromjpeg($fullpath);  }
		else if ($ext == "gif") { $src = imagecreatefromgif($fullpath); }
		else if ($ext == "png") { $src = imagecreatefrompng($fullpath); }
		list($width,$height)=getimagesize($fullpath);
		$newwidth=600;
		$newheight=($height/$width)*600;
		$tmp=imagecreatetruecolor($newwidth,$newheight);
		imagecopyresampled($tmp,$src,0,0,0,0,$newwidth,$newheight,$width,$height);

		if ($ext == "jpg") { imagejpeg($tmp,$fullpath,100); }
		else if ($ext == "gif") { imagegif($tmp,$fullpath,100); }
		else if ($ext == "png") { imagepng($tmp,$fullpath,100); }
			
		imagedestroy($src);
		imagedestroy($tmp); 
		}

I'm still getting this error (warning, really):

Warning: Cannot modify header information - headers already sent by (output started at /*full path*/upload_window.php:496) in /*full path*/upload_window.php on line 620

Line 620 is the <!DOCTYPE> declaration, FYI.

Thanks again for any help.

Headers already sent is almost always caused by whitespace ( space / tab / new line ) before the opening <?php or after the closing ?>

Good luck

Thank you, thank you. It's working perfectly now. Here's the final code starting after line 488 of the original upload_window.php file for anyone interested:

		// Store File object into DB:
		$newFile->dbsave();
		//LOKO RESIZE MOD **********************
		$ext = substr( $newFile->dget('name'), strrpos($newFile->dget('name'), '.') + 1 ); //GETS THE EXTENSION
		$fullpath = $newFile->get_full_path();
		if ($ext == "jpg" or $ext == "gif" or $ext == "png") {
			if ($ext == "jpg") { $src = imagecreatefromjpeg($fullpath); }
			else if ($ext == "gif") { $src = imagecreatefromgif($fullpath); }
			else if ($ext == "png") { $src = imagecreatefrompng($fullpath); }
			list($width,$height)=getimagesize($fullpath);
			$newwidth=600;
			$newheight=($height/$width)*600;
			$tmp=imagecreatetruecolor($newwidth,$newheight);
			imagecopyresampled($tmp,$src,0,0,0,0,$newwidth,$newheight,$width,$height);
			if ($ext == "jpg") { imagejpeg($tmp,$fullpath,100); }
			else if ($ext == "gif") { imagegif($tmp,$fullpath,100); }
			else if ($ext == "png") { imagepng($tmp,$fullpath,100); }
			imagedestroy($src);
			imagedestroy($tmp); 
		}
		//EOF LOKO MOD *************************

I realized that the resize was also resizing images smaller than 600px, so I added a conditional to take care of that.

//line 491 LOKO RESIZE MOD **********************
		$ext = substr( $newFile->dget('name'), strrpos($newFile->dget('name'), '.') + 1 ); //GETS THE EXTENSION
		$fullpath = $newFile->get_full_path();
		list($width,$height)=getimagesize($fullpath);
		if ($width > 599 or $height > 599) {
			if ($ext == "jpg" or $ext == "gif" or $ext == "png") {
				if ($ext == "jpg") { $src = imagecreatefromjpeg($fullpath); }
				else if ($ext == "gif") { $src = imagecreatefromgif($fullpath); }
				else if ($ext == "png") { $src = imagecreatefrompng($fullpath); }
				$newwidth=600;
				$newheight=($height/$width)*600;
				$tmp=imagecreatetruecolor($newwidth,$newheight);
				imagecopyresampled( $tmp,$src,0,0,0,0,$newwidth,$newheight,$width,$height );
				if ($ext == "jpg") { imagejpeg($tmp,$fullpath,100); }
				else if ($ext == "gif") { imagegif($tmp,$fullpath,100); }
				else if ($ext == "png") { imagepng($tmp,$fullpath,100); }
				imagedestroy($src);
				imagedestroy($tmp); 
			}
		}
		//EOF LOKO MOD *************************

It's nice to see this solved :)

Plugin updated to v0.4

New: each post may have its own directory for uploaded files (created automatically). No more mess in media folder and no more "the file already exists" errors.

Added pt_BR Brazilian translation. Thanks to Walter

1st Question:
I'm wondering how to change the default code block that says "<div class='image_block'>" etc? I've looked in upload_window.php and it looks like this is set around line 465, but I can't figure out how to get it to say what I want.

2nd Question:
I'm using my own addition which resizes the images upon upload (see my previous posts in this thread). I upgraded to version 0.4 and am now getting this error (the asterisks are for privacy):

Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 3072 bytes) in /****/****/public_html/blog/plugins/quick_upload_plugin/upload_window.php on line 507

Line 507 is the part of my own code that does the resizing:

if ($ext == "jpg") { $src = imagecreatefromjpeg($fullpath); }

I've tried to set the upload_max_filesize, post_max_size, and memory_limit in php.ini to rediculously high amounts, but I still get the error. I have the php.ini file in the same directory as the upload_window.php file and I've also tried it in the root directory of the blog.

Thanks for any help. Here is the URL of my blog should you need it: http://www.oleniks.net/blog/lance.php

1
Edit the following code starting on the line 463

if( get_param('mode') == 'upload' )
{	// TODO: Add plugin hook to allow generating JS insert code(s)
	$img_tag = format_to_output( $newFile->get_tag(), 'formvalue' );
	$img_tag = preg_replace( 'class="image_block"', 'class="my_class"', $img_tag );

Not tested

2
php.ini must be in your root directory.
"Allowed memory size of 33554432 bytes exhausted" means that the limit is 32M. If you want to deal with images set it to 64M.
Make sure your host reads the php.ini file, it may just ignore custom config.

Thanks sam2kb.

Unfortunately, it didn't work. What I mean is, it didn't replace the existing tag; it just left it as it was. Any other options or ideas?

I really appreciate the help.

My bad, change preg_replace to str_replace

Thanks again for the reply. Unfortunately, that didn't work either. I've figured out the memory error, but still can't change the input tag value to what I want. I actually want to replace this:
<div class="image_block"><img src="path/file.jpg" alt="" title="" width="480" height="320" /></div>

with this:

<a class="image_block" href="path/file.jpg" rel="lightbox"><img src="path/file.jpg" alt="" title="" /></a>

So its not just the class information, its the whole tag. I want to auto-add the lightbox functionality and remove the width/height, since I have that coded in the CSS.

Ok, so I'm not that great at PHP, but I figured out how to change the input value to what I want. In the original upload_window.php, I changed this code:

		if( get_param('mode') == 'upload' )
		{
			// TODO: Add plugin hook to allow generating JS insert code(s)
			$img_tag = format_to_output( $newFile->get_tag(), 'formvalue' );
			$success_msg .= '<ul>'
					.'<li><input type="text" value="'.$img_tag.'" size="50" /></li>'
					.'<li><a href="#" onclick="if( window.focus && window.opener ){ window.opener.focus(); textarea_wrap_selection( window.opener.document.getElementById(\'itemform_post_content\'), \''.format_to_output( $newFile->get_tag(), 'formvalue' ).'\', \'\', 1, window.opener.document ); } return false;">'.T_('Add the code to your post !').'</a></li>';

to this:

		$pathinfo = $newFile->get_full_path(); 
		$pathinfo = str_replace("/home2/olenikso/public_html", "http://www.oleniks.net",$pathinfo); 
		$newimg_tag = "<a rel=&quot;lightbox&quot; class=&quot;image_block&quot; href=&quot;".$pathinfo."&quot;><img src=&quot;".$pathinfo."&quot; alt=&quot;&quot; title=&quot;&quot; /></a>";
		$newli_tag = "<li><input type='text' id='putinpost' value='.$newimg_tag.' size='50' /></li>";
			$success_msg .= '<ul>'
					.$newli_tag 
					.'<li><a href="#" onclick="if( window.focus && window.opener ){ window.opener.focus(); textarea_wrap_selection( window.opener.document.getElementById(\'itemform_post_content\'), \''.$newimg_tag.'\', \'\', 1, window.opener.document ); } return false;">'.$this->T_('Add the code to your post !').'</a></li>';	

Please give me suggestions on simplifying, if possible.

Try this

if( get_param('mode') == 'upload' )
{	// TODO: Add plugin hook to allow generating JS insert code(s)			
	$img = '<img src="'.$newFile->get_url().'" '
			.'alt="'.$newFile->dget('alt', 'htmlattr').'" '
			.'title="'.$newFile->dget('title', 'htmlattr').'" '
			.' />';
	
	$img_tag = '<a class="image_block" href="'.$newFile->get_url().'" rel="lightbox">'.$img.'</a>';
	$img_tag = format_to_output( $img_tag, 'formvalue' );
	
	$success_msg .= '<ul>'
etc...

Sam help!

I upgraded to v3.3 of b2 on two of my four blogs so far. On the first one this plug in is working fine but on the second (my main blog!) it's not.

I thought maybe there was a file issue so I deteled all the files and ran the upgrade again. I tried copying the files from the back of the blog that works fine. I downloaded the plug in again and reinstalled. I cleared the rendered cache under Misc but all I get is this when I click the button:

http://foreverpurple.com/images/quickupload.jpg

Are these blogs located on the same server?

Yes they are.

I'm having upload issues period. I'm starting to think my media folder is borked. I can't even change the permissions on it or delete anything.

I am going to try deleting it and see if the folders will recreate on their own.

I think you won't be able to delete it. Just download all pictures from it, create media2, and then upload all images back.

You can change media folder location from Blog setting > Advanced tab.

I can't delete anything in there, or I couldn't and I think it was a left over problem from the Avatars plug in. Anyway my webhost deleted it for me and now things are fine.

Avatars plugin creates new directories (Quick upload does it too), these directories belong to Apache user and may be not writable for hosting owner (you).

This depends on server configuration

All of a sudden today, the Quick Upload plugin is inserting uploaded images as links to the image file rather than putting the actual image in the blog post. I haven't made any changes to my b2evo configuration and my server PHP settings haven't been changed either. What's going on and how can I fix this?

Make sure you're in HTML mode if you use TinyMCE editor.

tip for a next release (if any) :
quick upload checks if the post is saved allready, so it's behaving the same as the upload button under the post (that one is first saving the post and only then you can start uploading)

check if you are in html-mode and/or force the html-mode

If the post is not saved you can still upload and insert images into it, but they won't be put in a separate folder (if selected in plugin settings) and you won't be able [u]to link[/u] uploaded files.

sam2kb wrote:

If the post is not saved you can still upload and insert images into it, but they won't be put in a separate folder (if selected in plugin settings) and you won't be able [u]to link[/u] uploaded files.

I know,
It's exactly for those reasons I make the suggestions for a possible next release of the plugin.

I know I need to save first before I can link, but I seem to be unable to explain my co-authors. They keep insirting the image, and then I always have to go edit the post, delete the inserted image and make a link.

Thanks for the quick answers - first thing I checked was HTML/WYSIWYG mode. I checked again with our provider on PHP changes and turns out the shared server was clogged up with log files, so space had run out. As soon as those got cleared off, everything worked fine once more.

@tivogirl
Sounds good

@Topanga
There's no way to link an image to the post if we don't know post ID. And there's no ID assigned the the post until you save it. Same applies to default b2evo file manager.
What we can do is require users to save the post before opening an upload window.

sam2kb wrote:

There's no way to link an image to the post if we don't know post ID. And there's no ID assigned the the post until you save it. Same applies to default b2evo file manager.
What we can do is require users to save the post before opening an upload window.

I understand completely, no worries ;)

It's that in 3.3.1, when creating a new article, and when you want to attach/upload a file with the default fileuploader the button says : save and start uploading
Before you can start uploading, the article gets saved. And with that action, the article has a postID.
So you don't need to ask the user to save the post first, just do it, That way you ack as de core system. (if possible save the post as draft, but I will not argue for that.)

On my old blog, I could start writing a post and add images to it without saving it. Why was this changed in the new version?. If someone has publish check and writes a post and want to add an image and hits save to upload, the post will be published and pinged out when it is not finished. This is a bad thing. Who thought up this idea? This is a bad thing and it needs to be changed. The old way managed to work just fine and that is the way I want the new version to work. So what do I need to hack to get this working properly again. Saving and publishing a blog post that is not finished to upload images is a BAD thing, as it will ping out and people will start coming to a post that is not ready!

If the post is not saved [u]you can still upload and insert[/u] images into it, but they won't be put in a separate folder (if selected in plugin settings) and you won't be able to link uploaded files.

Kimberly wrote:

On my old blog, I could start writing a post and add images to it without saving it. Why was this changed in the new version?. If someone has publish check and writes a post and want to add an image and hits save to upload, the post will be published and pinged out when it is not finished. This is a bad thing. Who thought up this idea? This is a bad thing and it needs to be changed. The old way managed to work just fine and that is the way I want the new version to work. So what do I need to hack to get this working properly again. Saving and publishing a blog post that is not finished to upload images is a BAD thing, as it will ping out and people will start coming to a post that is not ready!

Thats why the core version has 'draft' as default.
But you can not link files to an unpublished post. For the reasons Sam has explained.
You can insert images though, so if you only insert images, and never linked your images, you don't have to worrie.

The download link seems to be dead for 0.4.

Fixed. Thanks a lot.
Seems like it was dead for about a month 8|

Thanks. :)

I have a small problem with translating the plugin. I made a new locale for Finnish and copied the Russian translation as the base. I then changed all the locale settings and translated the strings.

But when I try to use the translation, the scandinavian letters (ä, ö) don't display correctly.

I checked with other plugins and the main translation, and they seem to use the same settings.

For example in the post screen, all the other translation strings are displayed correctly but the quick upload strings aren't.

What could cause this?

What encoding do you use? Can you please PM me a link to your translation, I'll fix it and include in next release.

Plugin updated to v0.5

- Now supports b2evolution 4
- fixed minor bugs
- improved usability

Hi there,

the plugin works fine for me. But the code which is given out ("Add this to your blog post") is not fitting my needs perfectly. So I have to edit the code manually every time.
At first sight I did not find a way to change the outpu code. Could anyone give me a hint?

Kind regards, pgs

That code is not setup in the plugin, it's the default code b2evo creates. I can make it editable so one could change it in plugin settings.

Added in todo list.

Thanks a lot!

Kind regards, pgs

This plugin does not work in V504. Will there be an update?

image links in original post are broken. what is this plugin supposed to do which b2evo v5 doesn't do?

Basically I want to be able to upload files without having to save the post first. It's just a personal preference.

In addition to previous comment, now I remember another reason why I prefer using this plugin. One of my blogs is image intensive and has lots of files (1000+) in a directory. It takes time to load and takes time to filter through the list (I'm on a slow server) to locate files to be used for a given post. This plugin is quick as it doesn't display files and simplifies the upload process. It simply uploads and just display functions to insert the uploaded files. With what comes with V5, there are additional steps after popup - it lists file list, then I have to click upload tab to upload files, after files are uploaded I have to return back to browse tab to locate files to insert into post. Perhaps enhance the upload screen to provide links to quickly insert files to post?

We will enhance the upload process indeed.

I edited the post to show images

@iceblock
What errors to you get? What exactly is not working?

I updated the plugin, it should work in v5 now.