1 davidnewcomb Mar 13, 2018 20:36
3 fplanque Mar 15, 2018 16:48
Thanks, will fix.
4 davidnewcomb Mar 23, 2018 16:00
Sorry for the delay. Thanks for a link to the commit. I've switched on "watching all conversations" on GitHub, so I think that'll let me know about new commits.
I really wish there was a bit more help for developers. The documentation should contain at least something about the source, something like what the maze of branches are for or which branch to branch from when trying to submit patches. It just seems unnecessarily complicated to get up and running. It would also seem that the best way to install b2e is by cloning the github repo and not from a zip file, blending in unreleased patches released at different times with your own fixes is a nightmare. Oh, I can feel a rant coming on so maybe I'll blog about that instead ;)
In real life I'm a Java Dev and use Eclipse all the time so when they released Eclipse PDT it was the logical option and it's brilliant for both languages; I hear their C++ environment is coming along nicely. They all work in the same way and link with xdebug etc. The refactoring tools are great for Java but getting better for PHP. Anyway check it out.
https://www.eclipse.org/pdt/
http://www.bigsoft.co.uk/blog/index.php/2014/10/21/debugging-php-in-eclipse
This post has 4 feedbacks awaiting moderation...
I've been looking at this issue and think I have found the cause of the problem.
The
/plugins/shortlinks_plugin/_shortlinks.plugin.php
page stores its plugin settings using achecklist
type.This looks like a half-implemented feature! Reading the
checklist
type from the database expects a PHP serialised key-value array. Saving thechecklist
type resets the array of new options to null, inCollectionSettings->set( $col_key1, $col_key2, $value )
because it passes the checklist array toutf8_substr()
which returns null. So "" is saved to the database for plugin<id>_link_types. Once "" is saved into the database there is no object to de-serialise and so all the options are blank. It looks like it works at the beginning because there is no correspondinglink_types
record in the databases and the defaults are used.There are 2 ways to fix this:
checklist
type with a number ofcheckbox
types (same solution as the markdown plugin and all the others).2) In file
/inc/plugins/_plugin.funcs.php
:This converts the array into a serialised string so that it can be safely saved as normal. It feels a bit like a hack so maybe you can think of a better place to put the code that prepares the
checklist
data type for saving.