Recent Topics

1 Jan 18, 2011 14:58    

After upgrading to the 4.0.x series (verified with latest 4.0.3) I realized that the icons for banning URLs or deleting comments in the admin backoffice don't show up when usgin google chrome browser. Everything displays nicely in firefox, but not in chrome.

After digging around I found a couple of errors in the HTML. Here's a patch to fix it:

=== modified file 'inc/comments/model/_comment.class.php'
--- inc/comments/model/_comment.class.php       2010-11-08 13:37:47 +0000
+++ inc/comments/model/_comment.class.php       2010-12-26 23:24:39 +0000
@@ -738,7 +738,7 @@
 
                if( $ajax_button )
                {
-                       echo ' <a href="javascript:delete_comment_url('.$this->ID.');"'.get_icon( 'delete' ).'</a>';
+                       echo ' <a href="javascript:delete_comment_url('.$this->ID.');">'.get_icon( 'delete' ).'</a>';
                }
                else
                {
@@ -785,7 +785,7 @@
 
                if( $ajax_button )
                {
-                       echo ' <a id="ban_url" href="javascript:ban_url('.'\''.$authorurl.'\''.');"'.get_icon( 'ban' ).'</a>';
+                       echo ' <a id="ban_url" href="javascript:ban_url('.'\''.$authorurl.'\''.');">'.get_icon( 'ban' ).'</a>';
                }
                else
                {

=== modified file 'inc/comments/model/_comment.funcs.php'
--- inc/comments/model/_comment.funcs.php	2010-10-26 20:31:03 +0000
+++ inc/comments/model/_comment.funcs.php	2010-12-26 23:21:20 +0000
@@ -312,7 +312,7 @@
 function add_jsban( $url )
 {
 	$url = rawurlencode(get_ban_domain( $url ));
-	return '<a id="ban_url" href="javascript:ban_url('.'\''.$url.'\''.');"'.get_icon( 'ban' ).'</a>';
+	return '<a id="ban_url" href="javascript:ban_url('.'\''.$url.'\''.');">'.get_icon( 'ban' ).'</a>';
 }
 
 
@@ -396,4 +396,4 @@
 /*
  * $Log: _comment.funcs.php,v $
  */
-?>
\ No newline at end of file
+?>

As you can see there's a missing ">" in each case.

2 Jan 23, 2011 01:14

Oh thankyouthankyouthankyou! I was just looking for this! Will edit and test this immediately. I'm always cleaning spam and those little icons are key for me (since the only browser I use is Chrome).

3 Jan 23, 2011 20:19

Cool :) Thanks for the patch

Added to CVS

4 Jan 09, 2012 19:27

Thanks for the patch! Been looking for something like this!


Form is loading...