Recent Topics

[5.2.1] comment list widget - missing space

Started by on Feb 05, 2015 – Contents updated: Feb 14, 2015

Feb 05, 2015 05:43    

Modified /inc/widgets/widgets/_coll_comment_list.widget.php line 191 to read echo T_( ' on ' ); as there was no space between the username and the word 'on'.

Feb 14, 2015 10:53

Hi @arinaya,

Thanks for sharing.

Let me disagree on this. I mean, I think that string doesn't need any additional space. Actually, as I see, it should be echo T_( 'on' );, because the spaces are inserted by the functions called before and after that line. As you can see in spaces_on_translation_strings__widget_code.png, those functions are set to work that way. If you want, you can download the PHPXref of the code from here: https://github.com/mgsolipa/b2evolution_phpxref and check those functions (they are both in the file /blogs/inc/comments/model/_comment.class.php).

However, can you please tell us where did you see this working wrong?, because, as far as I know, it is visually correct right now.

Actually, going a little bit further, if you see spaces_on_translation_strings__html.png, based on how the code is currently working, there are two blank spaces after the word 'on', so if we add an additional space to the translatable string, a second space will be also added before.

Regards!

spaces_on_translation_strings__widget_code
spaces_on_translation_strings__html


Form is loading...

multi-blog engine – This forum is powered by b2evolution CMS, a complete engine for your website.