1 orator Mar 08, 2007 15:30
3 orator Mar 08, 2007 16:39
Solved again!
I wish I had all your knowledge, I wouldn't be here taking your time... :)
Thx a lot friend,
Orator
4 yabba Mar 08, 2007 17:25
but then I'd be out of a job ;)
¥
5 blueyed Mar 08, 2007 18:23
¥åßßå, can you commit this fix to CVS into v-1-9, v-1-10 and HEAD, please?
6 yabba Mar 08, 2007 23:55
One problem, every time I commit summat François worries in case I've bust his core, imagine how he'll feel when I do it to all three at once :roll:
I'll make the changes in the morning whilst he's asleep ;)
¥
7 blueyed Mar 09, 2007 00:09
He plans to release 1.9.3 in the next hours/days.
IMHO this fix should make it into there (at least it prevents you from deleting blogs AFAICS), and it's the same issue in v-1-10 probably - but HEAD is likely to work fine.
It seems to only happen if you're coming from a post-delete though, is it so? Because creating a blog and deleting it straight afterwards does work.
8 yabba Mar 09, 2007 00:21
It's because the form "expects" to be on the blogs tab so it doesn't set the "ctrl" parameter (explicitly). So far I've not found any repercussions, but I've not really tested much.
I'll upload the change in the morning once I find all three branches ;)
¥
*edit* it also happens after making a new post ( admin > write > save > bloglist below all ping notifications, delete urls read http://demo.b2evolution.net/v-1-9/blogs/admin.php?blog=<blog id>&ctrl=editactions&action=delete&blog=2 ), it's the same cure though
*edit 2*
Wierd, I just checked and the url really does have "blog=##" in it twice (once at start and once at end)
*edit 3 .... damn, I'm on a roll :|*
it looks like this :-
<a href="<?php echo regenerate_url( 'action', 'action=delete&blog='.$curr_blog_ID ) ?>
Needs to be :-
<a href="<?php echo regenerate_url( array('action','ctrl', 'blog'), 'ctrl=collections&action=delete&blog='.$curr_blog_ID ) ?>
I really haven't checked that one though
9 yabba Mar 09, 2007 11:01
I've updated 1.9.3 & 1.10. The same problem doesn't appear to occur in 2.0
¥
Looks like you just found a bug ;)
inc/view/collections/_bloglist.php ( approx line 125 )
Add the bits in red and it should work :-
¥