1 mikeyboy Sep 03, 2004 19:17
3 russhall Jul 11, 2005 01:24
Guys, I just wanted to thank you for your work on this issue. Isaac, I have been able to implement your wonderful creation on my site and it is exactly what I was looking for. I have an inline frame (no flaming for that, please), and I was getting perturbed that external links would open in that frame. It seemed incredibly tedious to go through and alter all of the links and/or expect visitors who leave comments to add "_blank" tags. So, I found this and it works perfectly. It still opens comments in the iframe, but opens the commentor's site in a new window. Basically, I'm posting to show my appreciation and to add this to anyone else who might search for inline frame solutions. Thanks again.
Thanks, Mike.
I did push Mike to put this here just to get a solution up and running, and it gave me a start on doing it another way. I don't want to come off as poopooing his method, and I [url=http://isaacschlueter.com/blog/more_b2evo_hacking]even tried out something like it[/url]. But as I've thought about it more, using the target attrib is not really optimal. Also, you don't necessarily want local links to open new windows, even if you want remote links to (like on this forum.)
I posted another way to do this over at http://isaacschlueter.com/projects/new_window_links
You'd still do all the updating to your skin's _main.php file, where all the other XHTML is. Put keepYaLinksPoppin.js in your skin/skin_name folder, and then have a tag like this in the head section:
The advantage of Mike's system is that there's a checkbox that, when checked, makes the links behave one way, and when unchecked, they go back to normal. I haven't done that, but it shouldn't be too hard to stick it on.
[EDIT:]
Ok, after half an hour playing with it, it's trickier than I thought, or I'm just all JavaScripted out for the day. If a disableable feature is a must-have, then use Mike's method, but that's not as cross-browser.