1 xangelusx Aug 03, 2006 04:22
3 blueyed Aug 03, 2006 04:21
It's planned to allow relative URLs, but simultaneously it we must make sure that they are made absolute again in the XML/RSS feeds.
Basically, it should get fixed in validate_url() and where the content gets displayed for/through the feeds.
I think, in the feeds we should prepend the item's blog's url to any links (href and src attributes), which do not start with a protocol ("\w+://"). If the first char of the URI is not a slash, that should get added/kept from the blog url.
However, what about blog urls like http://example.com/index.php?blog=1 (versus own/sub-domain)? - I think we should use $baseurl, if the blog has no absolute URL without params (detected by question mark).
More thoughts? :)
(I'll split this thread)
4 xangelusx Oct 17, 2006 05:18
This fix should allow for links to "#some_internal_page_anchor" as well. Currently, you have to use a fully qualified URL and add the anchor to the end, which may not be what you want to happen.
For instance, I was trying to add a link in my blog's long description text to an anchor in my skin. The long description shows up everywhere that the skin is used, and the anchor will always be valid. But having to hard code the URL means a user could be on a specific post when they click the link, which now redirects them to the site root rather than just an internal anchor.
5 blueyed Oct 17, 2006 19:29
Very good point. Just committed for 1.9. Thanks for reporting.
6 xangelusx Oct 17, 2006 19:49
My pleasure!! :)
Here are the changes I implimented in 1.6. I haven't merged them into my copy of 1.8 yet, so the file names may have changed in the new version
conf/_formatting.php
evocore/_misc.funcs.php