Recent Topics

1 Jul 11, 2016 13:18    

Hi I have ongoing problems, for years when validating.

  1. Sort calendar plugin as usual

    [/plugins/calendar.plugin.php]
    Line 560 (parameters obsolete)
    delete callspacing="0" and rename summary to title
    Line 575
    delete abbr="[abbr]"

  1. On InSkin login page 2 errors

    error 1: Bad value for attribute action on element form: Must be non-empty. From line 161
    [inc/_core/_template.funcs.php] (@version $Id: _template.funcs.php
    function display_login_form( $params )
    Line 2262 empty 'form_action'=>' '; modified empty quotes to NULL
    error 2: <input tag="input" type="submit" class="btn-success btn-lg btn" name="login_action[login]" value="Log in!" /></div>
    OLD Resolution for Unacceptable {tag} attribute inside {input} tag
    file [/inc/core/ui/forms/_form.class.php]
    Lines: 2935, 3694, 3698
    change 'tag' to 'data-tag'
    see http://help.simplytestable.com/errors/html-validation/attribute-x-not-allowed-on-element-y-at-this-point/

This second error found when logging in page is up can be removed but causes glitches in back office where some show styling code rather than link object. So what can I do about this tag??

2 Jul 12, 2016 01:34

ok, we'll look at these issues.

3 Jul 12, 2016 06:03

Thanks

With the tag="input"error,
In [/inc/_core/ui/forms/_form.class.php]
Lines 2970, 3706, 3710

I have changed 'tag' as before to 'data-tag'.

As previously this removed the validation error but caused a glitch somewhere in the back office that I cannot find at the moment

4 Jul 12, 2016 15:40

Glitches after changing the tag attribute:

I think it's radio buttons, will have to undo my hack to find out.
Here's some images, top two poor quality for now, blue slot is the fa-filter type text

http://rogerlovejoy.net/blog/b2evo.php/tag-attribute-in-input

This is an old site I use for recording stuff, old version not validated :)

Ok Have sorted the back office widgets page

change 'tag' to 'data-tag'
[/inc/widgets/views/_widget_list.view.php]
Lines: 266,272,282,287,297,303

5 Jul 12, 2016 22:02

SORTED: All HTML5 Validation errors Whoopie!

tag attribute in input

The ongoing issue with adding a tag attribute to the input element. Changing it to data-tag gets rid of the HTML validation error but causes UI glitches.

error: Attribute tag not allowed on element input at this point.
From line 156, column 55; to line 156, column 163
See http://help.simplytestable.com/errors/html-validation/attribute-x-not-allowed-on-element-y-at-this-point/

change 'tag' to 'data-tag' in the following instances

[/inc/core/ui/forms/_form.class.php]
Lines: 2940,3706,3710
Causes UI glitches.

[/inc/widgets/views/_widget_list.view.php]
Lines: 266,272,282,287,297,303
removes glitches in back office widget form

[/inc/core/ui/forms/_uiwidget.class.php]
Line: 536
No obvious outcome

[/inc/items/view/_item_list_sidebar.view.php]
Line: 86, 318
Sorted glitch in back office Posts

6 Jul 12, 2016 23:13

Quick note: I'm not even sure we need tag=.. at all in the first place.

7 Jul 13, 2016 00:11

Ok I did wonder :) and after all this time lol

9 Aug 12, 2016 01:45

Hi Francois

If I'm not being too demanding RE: the second link above, referring to the action value not being empty.
Is it possible to explain to me, briefly how your solution is the proper one rather than the hack I did to line 2262 in [inc/_core/_template.funcs.php], by replacing the empty string with NULL ?

Is it because my hack would only resolve it for the login form and yours would resolve it if it occurred in any form?

Line
2254 function display_login_form( $params )
2255  {
2256   global $Settings, $Plugins, $Session, $Blog, $blog, $dummy_fields;
2257   global $secure_htsrv_url, $admin_url, $baseurl, $ReqHost, $redirect_to;
2258
2259   $params = array_merge( array(
2260     'form_before' => '',
2261     'form_after' => '',
2262     'form_action' => NULL,

10 Aug 12, 2016 19:30

I'm not the one who fixed this but yes I believe the fix we use is more general.


Form is loading...