1 amoun Jul 11, 2016 13:18
3 amoun Jul 12, 2016 06:03
Thanks
With the tag="input"
error,
In [/inc/_core/ui/forms/_form.class.php]
Lines 2970, 3706, 3710
I have changed 'tag' as before to 'data-tag'.
As previously this removed the validation error but caused a glitch somewhere in the back office that I cannot find at the moment
4 amoun Jul 12, 2016 15:40
Glitches after changing the tag attribute:
I think it's radio buttons, will have to undo my hack to find out.
Here's some images, top two poor quality for now, blue slot is the fa-filter type text
http://rogerlovejoy.net/blog/b2evo.php/tag-attribute-in-input
This is an old site I use for recording stuff, old version not validated :)
Ok Have sorted the back office widgets page
change 'tag' to 'data-tag'
[/inc/widgets/views/_widget_list.view.php]
Lines: 266,272,282,287,297,303
5 amoun Jul 12, 2016 22:02
SORTED: All HTML5 Validation errors Whoopie!
tag attribute in input
The ongoing issue with adding a tag attribute to the input element. Changing it to data-tag gets rid of the HTML validation error but causes UI glitches.
error: Attribute tag not allowed on element input at this point.
From line 156, column 55; to line 156, column 163
See http://help.simplytestable.com/errors/html-validation/attribute-x-not-allowed-on-element-y-at-this-point/
change 'tag' to 'data-tag' in the following instances
[/inc/core/ui/forms/_form.class.php]
Lines: 2940,3706,3710
Causes UI glitches.
[/inc/widgets/views/_widget_list.view.php]
Lines: 266,272,282,287,297,303
removes glitches in back office widget form
[/inc/core/ui/forms/_uiwidget.class.php]
Line: 536
No obvious outcome
[/inc/items/view/_item_list_sidebar.view.php]
Line: 86, 318
Sorted glitch in back office Posts
6 fplanque Jul 12, 2016 23:13
Quick note: I'm not even sure we need tag=..
at all in the first place.
7 amoun Jul 13, 2016 00:11
Ok I did wonder :) and after all this time lol
8 fplanque Aug 11, 2016 23:06
Some of these issues were fixed here:
- https://github.com/b2evolution/b2evolution/commit/efb76d5db2b4d8b7e3d9296f5279b77d07a94e84
- https://github.com/b2evolution/b2evolution/commit/db86b08da74c93efeaea60b3fff5f888e9927a60
This will be part of release 6.7.5
9 amoun Aug 12, 2016 01:45
Hi Francois
If I'm not being too demanding RE: the second link above, referring to the action value not being empty.
Is it possible to explain to me, briefly how your solution is the proper one rather than the hack I did to line 2262 in [inc/_core/_template.funcs.php], by replacing the empty string with NULL ?
Is it because my hack would only resolve it for the login form and yours would resolve it if it occurred in any form?
Line
2254 function display_login_form( $params )
2255 {
2256 global $Settings, $Plugins, $Session, $Blog, $blog, $dummy_fields;
2257 global $secure_htsrv_url, $admin_url, $baseurl, $ReqHost, $redirect_to;
2258
2259 $params = array_merge( array(
2260 'form_before' => '',
2261 'form_after' => '',
2262 'form_action' => NULL,
10 fplanque Aug 12, 2016 19:30
I'm not the one who fixed this but yes I believe the fix we use is more general.
ok, we'll look at these issues.