Recent Topics

1 Aug 30, 2015 04:27    

I have been doing these for years, so I'm asking that they be incorporated in the files permanently.

I will not list all here but a few that I find essential to start with.

With the in-skin login page:

  1. [inc/_core/_template.funcs.php]
    Line 2186: empty action; modified to NULL

  2. [/inc/core/ui/forms/_form.class.php] (took a while to find this one)
    Unacceptable {tag} attribute inside {input} tag
    Lines: 2935, 3694, 3698
    change 'tag' to 'data-tag'
    see http://help.simplytestable.com/errors/html-validation/attribute-x-not-allowed-on-element-y-at-this-point/

When logged in

  1. [inc/users/model/_user.func.php] Lines (193,199,235,236,213,217,219,236,704,768)
    Did all lines mentioned but (235 and 236) removed errors
  2. [/plugins/calendar.plugin.php]
    Cellspacing not valid attribute
    summary not valid attribute
    'attr' not valid attribute
    Line 437 removed cellspacing="0" and replaced the word summary with title
    Line 452 removed abbr="[abbr]"

OK Thanks

2 30 Aug 2015 10:44

@amoun what HTML5 validator are you using?

With the in-skin login page:

  1. [inc/_core/_template.funcs.php]
    Line 2186: empty action; modified to NULL

Does the error disappear after applying the change above? I mean, the empty form action remains in the code declaring form_action empty and also as NULL.

When logged in

  1. [inc/users/model/_user.func.php] Lines (193,199,235,236,213,217,219,236,704,768)
    Did all lines mentioned but (235 and 236) removed errors

Can you describe what error are you fixing here?

3 31 Aug 2015 03:45

  1. Sorry for omitting explanation in the second. They relate to the use of the '&' symbol rather than '&'

    E007 Found '&' within 'href'. You should use '&amp' instead:

    There are many cases of them in many files but (235 and 236) removed the obvious ones


  1. To remove validation error of empty action
    In the case of inserting the NULL as the action value, yes it solves the validation problem.
    line 2186 was

    'form_action' => '',

    now:

    'form_action' => NULL,

4 31 Aug 2015 06:58

@amoun all right. Please, tell us what validator are you using.

Thanks.


Form is loading...